Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for stale cachefiles #385

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add fallback for stale cachefiles #385

merged 1 commit into from
Nov 9, 2019

Conversation

timholy
Copy link
Owner

@timholy timholy commented Nov 9, 2019

Fixes #371. See also #383. Might fix #381

@timholy
Copy link
Owner Author

timholy commented Nov 9, 2019

xref #357. @KristofferC, do you think this will retrigger #356?

@KristofferC
Copy link
Collaborator

KristofferC commented Nov 9, 2019

If it tries to call ‘parse_cache_header‘ on a stale cache file, then probably.

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #385 into master will decrease coverage by 0.36%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   80.29%   79.92%   -0.37%     
==========================================
  Files          12       12              
  Lines        1370     1375       +5     
==========================================
- Hits         1100     1099       -1     
- Misses        270      276       +6
Impacted Files Coverage Δ
src/pkgs.jl 88.99% <69.23%> (-1.62%) ⬇️
src/recipes.jl 89.36% <0%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a7c13...ead2c3c. Read the comment docs.

@timholy
Copy link
Owner Author

timholy commented Nov 9, 2019

They can be stale for many reasons, here the reason is https://github.com/JuliaLang/julia/blob/72126021e612e91289fddb4b9aa01d4d9ec96ba9/base/loading.jl#L1445.

I've wrapped the parse_cache_header in a try/catch, hopefully that will solve the problem. The only other thing I can think to do is modify the Manifest, and that seems like a bad idea.

@timholy timholy merged commit a8f4660 into master Nov 9, 2019
@timholy timholy deleted the teh/fix371 branch November 9, 2019 12:55
aviatesk added a commit to JunoLab/Atom.jl that referenced this pull request Nov 11, 2019
aviatesk added a commit to JunoLab/Atom.jl that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants